: python/monarch: pytorch InputBuffer::add() signature changed #1739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@shayne-fletcher has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86025607. |
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 1, 2025
…pytorch#1739) Summary: pytorch `InputBuffer::add` API changed. adapt `monarch/python/monarch/_gradient_generator.cpp` ``` realInputBuffer(node).add( input_nr, check_and_reduce(node->node, input_nr, std::move(t)), std::nullopt, std::nullopt); // Remove: node->node ``` that gradient computation still works correctly after this change needs to be tested. Differential Revision: D86025607
shayne-fletcher
force-pushed
the
export-D86025607
branch
from
0927ecd to
5d8c0f7
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 1, 2025
…pytorch#1739) Summary: pytorch `InputBuffer::add` API changed. adapt `monarch/python/monarch/_gradient_generator.cpp` ``` realInputBuffer(node).add( input_nr, check_and_reduce(node->node, input_nr, std::move(t)), std::nullopt, std::nullopt); // Remove: node->node ``` that gradient computation still works correctly after this change needs to be tested. Reviewed By: vidhyav Differential Revision: D86025607
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 1, 2025
…pytorch#1739) Summary: pytorch `InputBuffer::add` API changed. adapt `monarch/python/monarch/_gradient_generator.cpp` ``` realInputBuffer(node).add( input_nr, check_and_reduce(node->node, input_nr, std::move(t)), std::nullopt, std::nullopt); // Remove: node->node ``` that gradient computation still works correctly after this change needs to be tested. Reviewed By: vidhyav Differential Revision: D86025607
…pytorch#1739) Summary: pytorch `InputBuffer::add` API changed. adapt `monarch/python/monarch/_gradient_generator.cpp` ``` realInputBuffer(node).add( input_nr, check_and_reduce(node->node, input_nr, std::move(t)), std::nullopt, std::nullopt); // Remove: node->node ``` that gradient computation still works correctly after this change needs to be tested. Reviewed By: vidhyav Differential Revision: D86025607
shayne-fletcher
force-pushed
the
export-D86025607
branch
from
5d8c0f7 to
de417b7
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Nov 1, 2025
…pytorch#1739) Summary: pytorch `InputBuffer::add` API changed. adapt `monarch/python/monarch/_gradient_generator.cpp` ``` realInputBuffer(node).add( input_nr, check_and_reduce(node->node, input_nr, std::move(t)), std::nullopt, std::nullopt); // Remove: node->node ``` that gradient computation still works correctly after this change needs to be tested. Reviewed By: vidhyav Differential Revision: D86025607
|
This pull request has been merged in f40f6db. |
Contributor
|
This pull request has been reverted by bb75826. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D86025607